fix: aggregate custom reporter results in run-workers --by suite (#5411)#5444
Closed
mirao wants to merge 1 commit intocodeceptjs:4.xfrom
Closed
fix: aggregate custom reporter results in run-workers --by suite (#5411)#5444mirao wants to merge 1 commit intocodeceptjs:4.xfrom
mirao wants to merge 1 commit intocodeceptjs:4.xfrom
Conversation
…eceptjs#5411) When using run-workers with --by suite, custom reporters (mochawesome, mocha-junit-reporter, etc.) only contained data from the last worker because each worker independently ran the reporter and overwrote the same output files. Strip custom reporters from worker configs and replay aggregated results through the reporter in the main thread after all workers complete. Handles both single-output and config.multiple (per-browser) scenarios with correct path resolution for nested reporter options. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
DavertMik
requested changes
Feb 25, 2026
Contributor
DavertMik
left a comment
DavertMik
left a comment
There was a problem hiding this comment.
No, this implementation seems like totally overrides how plugins are built and prefers mocha reporters instead. It adds additional complexity, hardcodes mocha reporters, and expothes them to codecept API
Code doesn't follow any project logic
Workers are for running Codecept API tests, enhancing mocha config on fly is a dangerous side-effect
Contributor
|
@mirao I would recommend to create a plugin for junit reporter instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run-workerswith--by suite, custom reporters (mochawesome, mocha-junit-reporter, etc.) only contained data from the last worker because each worker independently ran the reporter and overwrote the same output filesconfig.multiple(per-browser) scenarios with correct path resolution for nested reporter optionsTest plan
_runReporters()replays aggregated results through a custom reporter--by suiteconfig.multipleeach contain all suitesFixes #5411
🤖 Generated with Claude Code